js/src/admin/admin.js (2)

8458-8463: Builder change handler now conditionally runs range/step validation

Hooking validateNumberRangeSetting(target) and validateStepSetting(target) from handleBuilderChangeEvent behind ! frmGlobal.proIsConnected looks safe: both helpers guard on the element’s context (.frm-number-range / .frm-step) and will no-op for unrelated changes, so the extra work on the builder change stream is minimal while avoiding duplicate validation when Pro is connected.

If you want to tighten this further later, you could short‑circuit on target.closest('.frm-number-range, .frm-step') before calling either validator to avoid two function calls for clearly unrelated inputs.

---

11170-11180: Public frmAdminBuild.settings.validate API looks good; fill in @since

Exposing validateField, getRangeSettingsDefaults, validateNumberRangeSetting, and validateStepSetting under frmAdminBuild.settings.validate is a reasonable and coherent namespace, and aligns with how other helpers are surfaced from this module. The only nit is the JSDoc @since x.x placeholder above it; consider replacing this with the actual release version so downstream consumers know when this API became available.

js/src/admin/settings/validateRangeSettings.js (1)

51-120: Consider extracting common field lookup pattern.

Both validateNumberRangeSetting and validateStepSetting share a similar pattern for retrieving singleSettings, fieldId, and related input elements. Consider extracting this into a shared helper function to reduce duplication.

Example refactoring:

/**
 * Gets common field validation context.
 */
function getFieldContext( field, containerClass ) {
	if ( ! field.closest( containerClass ) ) {
		return null;
	}
	
	const singleSettings = field.closest( '.frm-single-settings' );
	const fieldId = getFieldId( singleSettings );
	
	return fieldId ? { singleSettings, fieldId } : null;
}

export function validateNumberRangeSetting( field ) {
	const context = getFieldContext( field, '.frm-number-range' );
	if ( ! context ) {
		return;
	}
	
	const { singleSettings, fieldId } = context;
	// ... rest of validation
}

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro